Use cwd from testem if configured else use default value #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Will review |
rwjblue
reviewed
Jan 8, 2019
There was a problem hiding this comment.
Can you explain why we need this change? It seems to directly reverse the prior position (that cwd would always be set to the outputPath), but doesn't really seem to offer reasoning...
Specifically, why would someone configure cwd in testem.js? Why would that override ember-cli's default cwd (the output path)?
|
There was a confusion because of internal monkey patching. This change is not needed. Am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If cwd is configured in testem.js file it should use it, else outputPath should be used as cwd.