Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 6 support #8563

Merged
merged 25 commits into from May 3, 2019

Conversation

Projects
None yet
7 participants
@Turbo87
Copy link
Member

commented Apr 8, 2019

ember-source@2.10.0-beta.1 has already dropped support for Node 6, which makes our test suite fail 馃槺

Merging this PR will break our support policy by having master (and beta) not be compatible with Node.js 6 anymore before its official EOL (2019-04-30), but since our parent project has already broken that promise I guess this is fine...

Turbo87 and others added some commits Feb 27, 2019

@Turbo87 Turbo87 requested a review from ember-cli/ember-cli Apr 8, 2019

@rwjblue

rwjblue approved these changes Apr 8, 2019

Show resolved Hide resolved .travis.yml

xg-wang and others added some commits Apr 9, 2019

@kellyselden
Copy link
Member

left a comment

I don't take breaking our policy lightly. I think we should either see if ember-source can revert, or not ship the incompatible version.

stefanpenner and others added some commits Apr 9, 2019

Merge pull request #8566 from xg-wang/bw
#8511 Mondernize build-watch.js build-watch-test.js
Merge pull request #8565 from xg-wang/next
Modernize git-init.js and git-init-test.js
#8511 Modernizes serve-test.js (#8570)
* #8511 Modernizes serve-test.js

* Fixes prettier errors

* Removes unused import
Merge pull request #8606 from Semeia-io/next
[Modernize] tests/unit/models/instrumentation-test.js
Merge pull request #8607 from Semeia-io/next-addon-test
[Modernize] tests/unit/models/addon-test.js
[Modernize] smoke-test-slow.js (#8574)
* [Monernize] smoke-test-slow.js

* Wrap with try finally
@Turbo87

This comment has been minimized.

Copy link
Member Author

commented May 3, 2019

alright. we're doing this!

@Turbo87 Turbo87 merged commit 3d6b7bc into beta May 3, 2019

5 checks passed

WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 89.757%
Details

@delete-merged-branch delete-merged-branch bot deleted the next branch May 3, 2019

This comment has been minimized.

Copy link
Contributor

commented May 3, 2019 — with Octobox

馃帀

@stefanpenner

This comment has been minimized.

Copy link
Contributor

commented May 4, 2019

馃懐鈥嶁檪

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.