Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENHANCEMENT blueprints] Fix ember-cli-htmlbars-inline-precompile deprecation #8875

Merged

Conversation

@HeroicEric
Copy link
Contributor

HeroicEric commented Oct 5, 2019

  • Drops ember-cli-htmlbars-inline-precompile from both app and addon blueprints
  • Bumps ember-cli-htmlbars from 4.0.1 to 4.0.5

Why?

Currently, generating a new ember app or addon and running it will result in the following deprecation:

DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json`

See ember-cli/ember-cli-htmlbars#317 for more details.

Steps to reproduce the current issue:

$ npm install -g ember-cli
$ ember new foo-app
$ cd foo-app
$ ember s
DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json`
- Drops `ember-cli-htmlbars-inline-precompile` from both app and addon
  blueprints
- Bumps `ember-cli-htmlbars` from
  [4.0.1](https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.0.1)
  to [4.0.5](https://github.com/ember-cli/ember-cli-htmlbars/releases/tag/v4.0.5)

Why?

Currently, generating a new ember app or addon and running it will
result in the following deprecation:

```
DEPRECATION: ember-cli-htmlbars-inline-precompile is no longer needed with ember-cli-htmlbars versions 4.0.0 and higher, please remove it from `/Users/eric/code/foo/package.json`
```

See ember-cli/ember-cli-htmlbars#317
for more details.

Steps to reproduce the current issue:

```bash
npm install -g ember-cli
ember new foo-app
cd foo-app
ember s
```
@rwjblue rwjblue changed the base branch from master to release Oct 7, 2019
@rwjblue rwjblue force-pushed the HeroicEric:silence-hbs-precompile-warning branch from af4e3b0 to f3fbf1d Oct 7, 2019
@rwjblue

This comment has been minimized.

Copy link
Member

rwjblue commented Oct 7, 2019

Updated PR to target release branch and rebased.

This comment has been minimized.

Copy link
Member

rwjblue commented Oct 7, 2019 — with Octobox

(thank you @HeroicEric!)

@rwjblue rwjblue merged commit 18df651 into ember-cli:release Oct 7, 2019
3 of 4 checks passed
3 of 4 checks passed
continuous-integration/appveyor/pr AppVeyor build failed
Details
WIP Ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 89.804%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.