Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Include legacyDecorators eslint option by default #8900

Conversation

@pzuraq
Copy link
Contributor

pzuraq commented Oct 23, 2019

Ember supports the legacy decorators proposal, which originally
placed the decorators before the export keywords. However, eslint
now throws errors if this is used, which is inline with the stage 2
spec that was rejected. This enables the legacyDecorators flag in
eslint to allow decorator placement anywhere.

@pzuraq pzuraq force-pushed the pzuraq:bugfix/include-legacy-decorators-option-by-default branch from 587db6e to e858e6f Oct 23, 2019
@pzuraq pzuraq changed the base branch from master to beta Oct 24, 2019
Ember supports the legacy decorators proposal, which originally
placed the decorators _before_ the export keywords. However, eslint
now throws errors if this is used, which is inline with the stage 2
spec that was rejected. This enables the legacyDecorators flag in
eslint to allow decorator placement anywhere.
@pzuraq pzuraq force-pushed the pzuraq:bugfix/include-legacy-decorators-option-by-default branch from e858e6f to b977099 Oct 24, 2019
@rwjblue rwjblue merged commit 59d9b9b into ember-cli:beta Oct 24, 2019
4 checks passed
4 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 89.81%
Details
@mehulkar

This comment has been minimized.

Copy link

mehulkar commented Nov 21, 2019

@pzuraq noticed this in my upgrade. Do you have an example of before and after? I'm not sure I understand what you mean by "placed decorators before the export keyword"

@pzuraq

This comment has been minimized.

Copy link
Contributor Author

pzuraq commented Nov 21, 2019

@decorator
export default MyClass {}

// vs
export default
@decorator
MyClass {}
@pzuraq pzuraq deleted the pzuraq:bugfix/include-legacy-decorators-option-by-default branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.