Update app/addon blueprints to ember-auto-import@2 #9623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quick Summary of Breaking Changes --------------------------------- - apps that have custom webpack config will need to check that their config is compatible with webpack 5 - apps must add webpack to their own dependencies (`yarn add --dev webpack@5` or `npm install --save-dev webpack@5`) - apps that were adding css handling (like `css-loader`, `style-loader`, and `MiniCSSExtraPlugin`) to the webpack config must remove those, because they're now included by default for compatibility with the embroider v2 package spec. - apps should confirm that their deployment strategy includes all files produced under `dist` (not just the traditional expected ones like `dist/assets/your-app.js` and `dist/assets/vendor.js`) - apps that use `fingerprint.prepend` to move their assets to a different origin will also need to set `autoImport.publicAssetURL`. See example below. - addons that upgrade to ember-auto-import >= 2 will only work in apps that have ember-auto-import >= 2, so they should do their own semver major releases when they upgrade - our `alias` option has changed slightly to align better with how it works in webpack - we dropped support for node < 12 and ember-source < 3.4 and ember-cli < 3.4. For more details read the 2.0 upgrading guide here: https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md
kategengler
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick Summary of Breaking Changes
yarn add --dev webpack@5ornpm install --save-dev webpack@5)css-loader,style-loader, andMiniCSSExtraPlugin) to the webpack config must remove those, because they're now included by default for compatibility with the embroider v2 package spec.dist(not just the traditional expected ones likedist/assets/your-app.jsanddist/assets/vendor.js)fingerprint.prependto move their assets to a different origin will also need to setautoImport.publicAssetURL. See example below.aliasoption has changed slightly to align better with how it works in webpackFor more details read the 2.0 upgrading guide here:
https://github.com/ef4/ember-auto-import/blob/main/docs/upgrade-guide-2.0.md