From a10df4ad4549ab0c35401e2c46a05baa5c15a0dd Mon Sep 17 00:00:00 2001 From: Bryan Mishkin <698306+bmish@users.noreply.github.com> Date: Tue, 17 Aug 2021 09:52:30 -0400 Subject: [PATCH] fix: crash in no-controller-access-in-routes --- lib/rules/no-controller-access-in-routes.js | 7 ++++++- tests/lib/rules/no-controller-access-in-routes.js | 6 ++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/lib/rules/no-controller-access-in-routes.js b/lib/rules/no-controller-access-in-routes.js index 91b7a03b48..4fa5fc0703 100644 --- a/lib/rules/no-controller-access-in-routes.js +++ b/lib/rules/no-controller-access-in-routes.js @@ -160,7 +160,12 @@ module.exports = { return; } - if (node.init.type !== 'ThisExpression' || node.id.type !== 'ObjectPattern') { + if ( + !node.init || + node.init.type !== 'ThisExpression' || + !node.id || + node.id.type !== 'ObjectPattern' + ) { return; } diff --git a/tests/lib/rules/no-controller-access-in-routes.js b/tests/lib/rules/no-controller-access-in-routes.js index 717f33de91..3674142671 100644 --- a/tests/lib/rules/no-controller-access-in-routes.js +++ b/tests/lib/rules/no-controller-access-in-routes.js @@ -65,6 +65,12 @@ ruleTester.run('no-controller-access-in-routes', rule, { const { foo } = this; const { controller } = bar; }, + myAction2() { + const controller = this; + }, + myAction3() { + let controller4; + }, }, }); `,