Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ember-template-imports to v3.4.1 #1767

Merged
merged 1 commit into from Feb 1, 2023

Conversation

gossi
Copy link
Contributor

@gossi gossi commented Feb 1, 2023

When using eslint-plugin-ember with pnpm, there are more reports when dependencies are not met. This happens when installing eslint-plugin-ember but not installing ember-cli-htmlbars, here is a screenshot:

Bildschirmfoto 2023-02-01 um 17 33 36

That is eslint-plugin-ember depends on ember-template-imports which prior to v3.4 had listed ember-cli-htmlbars as a required peer dependency. This was removed with this commit: ember-template-imports/ember-template-imports@d1c4bd3 and first released in v3.4.0 (v3.4.1 is the latest release as of now).

Dependabot already updated to version 3.4.0 and a PR #1764 for 3.4.1 is open. Functionality should already be checked by CI. Yet, for end-users receiving this upstream change from ember-template-imports, this requires a version bump in package.json - which this PR includes.

Let me know how I can help drive this forward, I'm trying to keep my pnpm install warning free 馃槀

@bmish bmish added the Bug label Feb 1, 2023
@bmish
Copy link
Member

bmish commented Feb 1, 2023

Thanks. It makes sense to update package.json in this case because of a required bug fix in the newer version.

Normally, we don't care too much that package.json is updated, as long as it has a range with the correct major version that allows users to use whatever minor/patch version they want (deleting/recreating a lockfile is one way to force yourself to get the newer version).

If we want to change the dependabot PRs to update package.json, we can update this config: https://stackoverflow.com/a/66819358

@bmish bmish changed the title bump ember-template-imports to v3.4.1 Bump ember-template-imports to v3.4.1 Feb 1, 2023
@bmish bmish merged commit bf81362 into ember-cli:master Feb 1, 2023
8 checks passed
@gossi
Copy link
Contributor Author

gossi commented Feb 1, 2023

Thanks for merging this.

I think dependabot is fine with the current setting, it sometimes needs manually selected updates like this one, which is fine I guess :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants