New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support scoped bundle names #63
feat: support scoped bundle names #63
Conversation
7cf3a9e
to
c4b1d90
Compare
@rwjblue @trentmwillis Looks like I could use some help getting tests to pass here. It appears that master started failing when jquery 3.3 was released: There's a note on the jquery release post that they are no longer testing in phantomjs 1.9. Should this project also drop support for that version? The other failure is a node test exceeding the two second test timeout. This may be due to my changes, but I don't think so. The failing test is the first to use |
c4b1d90
to
73161a1
Compare
73161a1
to
24be7a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing CI in #66! Now that things are in order, we can start moving forward here...
lib/asset-manifest-generator.js
Outdated
* @param {string} entry | ||
* @returns {BundleInfo} | ||
*/ | ||
function bundleInfoFromAssetEntry(entry) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like splitting this out into a stand alone function, which should make testing various combinations much easier. Can you export this function privately, and add some unit tests around expected inputs and outputs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! Adding tests gave me an opportunity to clean up some quirks that carried over from the original implementation.
24be7a5
to
73ef1e8
Compare
e.g. "@lennyburdette/some-engine".
73ef1e8
to
a9c4d51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thank you!
When using an engine in a package called "@lennyburdette/my-engine", I would like to keep the following strings consistent:
ember install @lennyburdette/my-engine
).this.mount('@lennyburdette/my-engine', { path: 'my-engine' })
.import Foo from '@lennyburdette/my-engine'
).Currently, ember-asset-loader generates the asset manifest using only the scope, not the full package name. This change detects package scopes and only generates bundles with full package names.