New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broccoli-conditional-debug and begin instrumenting. #407

Merged
merged 1 commit into from May 6, 2017

Conversation

Projects
None yet
2 participants
@rwjblue
Collaborator

rwjblue commented May 5, 2017

Adds broccoli-conditional-debug as a dependency and begins instrumenting the styles portions of the build.

Once this lands, we can run a build like:

BROCCOLI_DEBUG=ember-engines:* ember b

And the instrumented trees are copied into ./DEBUG/ subfolder so that you can easily inspect them:

ember-engines:eager-in-eager:engine-style:input
ember-engines:eager-in-eager:styles
ember-engines:eager-in-lazy-in-lazy:engine-style:input
ember-engines:eager-in-lazy-in-lazy:styles
ember-engines:eager-in-lazy:engine-style:input
ember-engines:eager-in-lazy:styles
ember-engines:eager:engine-style:input
ember-engines:eager:styles
ember-engines:lazy-in-eager:engine-style:input
ember-engines:lazy-in-eager:engine-style:output
ember-engines:lazy-in-eager:engine-style:postprocessed
ember-engines:lazy-in-eager:styles
ember-engines:lazy-in-eager:vendor-style:input
ember-engines:lazy-in-eager:vendor-style:pre-import
ember-engines:lazy-in-lazy:engine-style:input
ember-engines:lazy-in-lazy:engine-style:output
ember-engines:lazy-in-lazy:engine-style:postprocessed
ember-engines:lazy-in-lazy:styles
ember-engines:lazy-in-lazy:vendor-style:input
ember-engines:lazy-in-lazy:vendor-style:pre-import
ember-engines:lazy:engine-style:input
ember-engines:lazy:engine-style:output
ember-engines:lazy:engine-style:postprocessed
ember-engines:lazy:styles
ember-engines:lazy:vendor-style:input
ember-engines:lazy:vendor-style:pre-import
ember-engines:tree-invocation-order:engine-style:input
ember-engines:tree-invocation-order:engine-style:output
ember-engines:tree-invocation-order:engine-style:postprocessed
ember-engines:tree-invocation-order:styles
ember-engines:tree-invocation-order:vendor-style:input
ember-engines:tree-invocation-order:vendor-style:pre-import

To only debug a single engine, you could run:

BROCCOLI_DEBUG=ember-engines:<engine name here>:* ember b

Which would output:

ember-engines:lazy-in-lazy:engine-style:input
ember-engines:lazy-in-lazy:engine-style:output
ember-engines:lazy-in-lazy:engine-style:postprocessed
ember-engines:lazy-in-lazy:styles
ember-engines:lazy-in-lazy:vendor-style:input
ember-engines:lazy-in-lazy:vendor-style:pre-import
@trentmwillis

One smallish thing, but overall I like it!

Show outdated Hide outdated lib/engine-addon.js
Add broccoli-conditional-debug and begin instrumenting.
Adds [broccoli-conditional-debug](https://github.com/rwjblue/broccoli-conditional-debug)
as a dependency and begins instrumenting the styles portions of the build.

Once this lands, we can run a build like:

```
BROCCOLI_DEBUG=ember-engines:* ember b
```

And the instrumented trees are copied into `./DEBUG/` subfolder so that you can easily
inspect them.
@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue

rwjblue May 6, 2017

Collaborator

@trentmwillis - Ready for another look when you have time...

Collaborator

rwjblue commented May 6, 2017

@trentmwillis - Ready for another look when you have time...

@trentmwillis trentmwillis merged commit 739afb6 into ember-engines:master May 6, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment