Add broccoli-conditional-debug and begin instrumenting.#407
Merged
trentmwillis merged 1 commit intoMay 6, 2017
Conversation
trentmwillis
suggested changes
May 5, 2017
Contributor
trentmwillis
left a comment
There was a problem hiding this comment.
One smallish thing, but overall I like it!
| exclude: ['vendor/**/*.*'] | ||
| }); | ||
|
|
||
| return new BroccoliDebug(vendorCSSTree, this._debugLabel + ':vendor-style:input'); |
Contributor
There was a problem hiding this comment.
Minor suggestion: Can we create a helper function for constructing these labels? Maybe something like this._debugLabel('vendor-style:input'); and change the current _debugLabel to be _debugLabelPrefix or something?
It's not 100% necessary, but I feel it would be nicer and makes maintainability better in the long run (e.g. if we want to change the format or the labels).
Member
Author
There was a problem hiding this comment.
Good point! I actually built something into broccoli-conditional-debug for this in https://github.com/rwjblue/broccoli-conditional-debug/pull/1.
06d23d7 to
432d8bc
Compare
Adds [broccoli-conditional-debug](https://github.com/rwjblue/broccoli-conditional-debug) as a dependency and begins instrumenting the styles portions of the build. Once this lands, we can run a build like: ``` BROCCOLI_DEBUG=ember-engines:* ember b ``` And the instrumented trees are copied into `./DEBUG/` subfolder so that you can easily inspect them.
432d8bc to
09d5bed
Compare
Member
Author
|
@trentmwillis - Ready for another look when you have time... |
trentmwillis
approved these changes
May 6, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds broccoli-conditional-debug as a dependency and begins instrumenting the styles portions of the build.
Once this lands, we can run a build like:
And the instrumented trees are copied into
./DEBUG/subfolder so that you can easily inspect them:To only debug a single engine, you could run:
Which would output: