Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get tests passing again by testing against ember-data@3.8.0 instead of master #679

Merged
merged 7 commits into from Apr 11, 2019

Conversation

2 participants
@kiwiupover
Copy link
Contributor

commented Mar 29, 2019

tomdale/ember-cli-addon-tests#208

ember-cli-addon-test by default tests against ember-data#master this PR removes #master and uses ^3.8.0

adds node 10 to the test metrics
uses npm 6 or greater

@kiwiupover kiwiupover force-pushed the kiwiupover:get-tests-passing branch from f879514 to 2b3301a Mar 29, 2019

@kiwiupover kiwiupover force-pushed the kiwiupover:get-tests-passing branch from 9af3fe4 to 4928e3a Apr 6, 2019

@kiwiupover kiwiupover force-pushed the kiwiupover:get-tests-passing branch from 4928e3a to dd490d6 Apr 7, 2019

Moved fake-addon modules into the lib directory
package.json will reference the modules in the lib directory

@kiwiupover kiwiupover force-pushed the kiwiupover:get-tests-passing branch from bd0d035 to 80a4135 Apr 8, 2019

kiwiupover added some commits Apr 8, 2019

@mansona mansona added this to In progress in Fixing Testing Infrastructure via automation Apr 10, 2019

@mansona mansona moved this from In progress to Existing PRs to Review in Fixing Testing Infrastructure Apr 10, 2019

@rwjblue

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Pushed a commit to use the newly released version of ember-cli-addon-tests (0.11.1).

@rwjblue rwjblue merged commit ba9e689 into ember-fastboot:master Apr 11, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

Fixing Testing Infrastructure automation moved this from Existing PRs to Review to Done Apr 11, 2019

@rwjblue rwjblue added the internal label May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.