Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy Node.js support leftovers #120

Merged
merged 1 commit into from Oct 24, 2020

Conversation

@bobisjan
Copy link
Contributor

@bobisjan bobisjan commented Apr 12, 2020

This removes remaining leftovers of legacy Node.js support code #13.

@bobisjan bobisjan force-pushed the zonkyio:node-cleanup branch 2 times, most recently from 398691e to 9859a54 Apr 12, 2020
@@ -30,16 +30,12 @@
"compression": "^1.6.2",
"express": "^4.13.3",
"fastboot": "^2.0.0",
"fastboot-express-middleware": "^2.0.0",
"fs-promise": "^2.0.3",

This comment has been minimized.

@bobisjan

bobisjan Apr 12, 2020
Author Contributor

Not used anymore.

@@ -30,16 +30,12 @@
"compression": "^1.6.2",
"express": "^4.13.3",
"fastboot": "^2.0.0",
"fastboot-express-middleware": "^2.0.0",
"fs-promise": "^2.0.3",
"request": "^2.81.0"

This comment has been minimized.

@bobisjan

bobisjan Apr 12, 2020
Author Contributor

This is required by request-promise for testing only.

@bobisjan bobisjan force-pushed the zonkyio:node-cleanup branch from 9859a54 to 0ba7810 Apr 12, 2020
@bobisjan bobisjan changed the title Remove legacy Node.js support Remove legacy Node.js support leftovers Apr 12, 2020
@bobisjan bobisjan force-pushed the zonkyio:node-cleanup branch from 0ba7810 to aec7f3e Aug 16, 2020
@bobisjan
Copy link
Contributor Author

@bobisjan bobisjan commented Oct 24, 2020

@rwjblue, would you take a look?

@bobisjan bobisjan mentioned this pull request Oct 24, 2020
1 of 1 task complete
@@ -27,7 +27,7 @@ particular, you can provide a custom:

## Requirements

FastBoot App Server requires Node.js v4.2 or later.
FastBoot App Server requires Node.js v8 or later.

This comment has been minimized.

@rwjblue

rwjblue Oct 24, 2020
Member

Haha, I'd like to bump this again too but seems good to do separately...

This comment has been minimized.

@bobisjan

bobisjan Oct 24, 2020
Author Contributor

Yes 😬, #123 is the next step.

@rwjblue rwjblue merged commit d4a75a7 into ember-fastboot:master Oct 24, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue rwjblue added the enhancement label Oct 24, 2020
@bobisjan bobisjan deleted the zonkyio:node-cleanup branch Oct 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.