Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to ESLint #121

Merged
merged 1 commit into from Jul 21, 2020
Merged

Migrate to ESLint #121

merged 1 commit into from Jul 21, 2020

Conversation

@bobisjan
Copy link
Contributor

@bobisjan bobisjan commented Apr 12, 2020

No description provided.

@@ -65,8 +65,7 @@ class Worker {
this.error = message.error;
break;
case 'shutdown':
process.exit(0);
break;

This comment has been minimized.

@bobisjan

bobisjan Apr 12, 2020
Author Contributor

This was reported as Unreachable code due to the process.exit() above.

@bobisjan bobisjan force-pushed the zonkyio:eslint branch from 75aa27d to 8e6177a Apr 12, 2020
@bobisjan
Copy link
Contributor Author

@bobisjan bobisjan commented Jul 19, 2020

@rwjblue, @kratiahuja would you mind taking a look at this?

@rwjblue rwjblue merged commit 8898cbb into ember-fastboot:master Jul 21, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bobisjan bobisjan deleted the zonkyio:eslint branch Jul 21, 2020
@rwjblue rwjblue added the internal label Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.