Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose `distPath` on `reload` event #96

Merged
merged 2 commits into from May 6, 2020

Conversation

@nathanhammond
Copy link
Contributor

@nathanhammond nathanhammond commented Feb 22, 2019

This is the first step toward supporting a dynamically changed distPath. It does not address express-http-server's issues, but it is an incremental improvement.

@snewcomer
Copy link

@snewcomer snewcomer commented Jul 15, 2019

@kratiahuja if you have time 🙏to review.

@villander
Copy link

@villander villander commented Sep 21, 2019

@rwjblue can you take a look, please?

@bobisjan
Copy link
Contributor

@bobisjan bobisjan commented Apr 11, 2020

@kratiahuja can you please take a look?

@kratiahuja
Copy link
Contributor

@kratiahuja kratiahuja commented Apr 15, 2020

LGTM @rwjblue any objections ?

@rwjblue
rwjblue approved these changes May 6, 2020
@rwjblue rwjblue changed the title distPath fixes Expose `distPath` on `reload` event May 6, 2020
@rwjblue rwjblue merged commit 87bdbc6 into ember-fastboot:master May 6, 2020
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@rwjblue rwjblue added the enhancement label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
You can’t perform that action at this time.