fix: noUncheckedIndexedAccess issues
#1607
Conversation
| @@ -36,7 +36,7 @@ export default class FormatRelative extends Formatter<RelativeTimeFormatOptions> | |||
| const { format } = formatOptions; | |||
| let unit = formatOptions.unit; | |||
| let opts: RelativeTimeFormatOptions = formatOptions; | |||
| if (!unit && format && intl.formats.relative && (opts = intl.formats.relative[format])) { | |||
| if (!unit && format && intl.formats.relative && (opts = intl.formats.relative[format]!)) { | |||
There was a problem hiding this comment.
An alternative here would be to update line 39 to allow undefined options
let opts: RelativeTimeFormatOptions | undefined = formatOptions;Which also matches the current behaviour
There was a problem hiding this comment.
yeah that's actually better
addon/-private/utils/flatten.ts
Outdated
| @@ -24,7 +24,7 @@ export default function flatten<T>(src: NestedStructure<T>): Record<string, T> { | |||
| const hash = flatten(value); | |||
|
|
|||
| for (const suffix in hash) { | |||
| result[`${key}.${suffix}`] = hash[suffix]; | |||
| result[`${key}.${suffix}`] = hash[suffix]!; | |||
There was a problem hiding this comment.
Here we could check that hash[suffix] is not undefined, but that would change which keys would be added to result.
We could update result to allow undefined values
const result = new EmptyObject() as Record<string, T | undefined>;Line 30 has a similar issue
There was a problem hiding this comment.
we can check that hash[suffix] is not undefined as well
addon/macros/t.ts
Outdated
| @@ -15,7 +15,7 @@ function partitionDynamicValuesAndStaticValues(options: Record<string, string | | |||
| if (value instanceof Raw) { | |||
| staticValues[key] = value.valueOf(); | |||
| } else { | |||
| dynamicValues[key] = value; | |||
| dynamicValues[key] = value!; | |||
There was a problem hiding this comment.
Here we could check that value is not undefined, but again, that would change which keys would be added to dynamicValues.
We could update dynamicValues to allow undefined values
const dynamicValues = new EmptyObject() as Record<string, string | undefined>;
| @@ -36,7 +36,7 @@ export default class FormatRelative extends Formatter<RelativeTimeFormatOptions> | |||
| const { format } = formatOptions; | |||
| let unit = formatOptions.unit; | |||
| let opts: RelativeTimeFormatOptions = formatOptions; | |||
| if (!unit && format && intl.formats.relative && (opts = intl.formats.relative[format])) { | |||
| if (!unit && format && intl.formats.relative && (opts = intl.formats.relative[format]!)) { | |||
There was a problem hiding this comment.
yeah that's actually better
addon/-private/utils/flatten.ts
Outdated
| @@ -24,7 +24,7 @@ export default function flatten<T>(src: NestedStructure<T>): Record<string, T> { | |||
| const hash = flatten(value); | |||
|
|
|||
| for (const suffix in hash) { | |||
| result[`${key}.${suffix}`] = hash[suffix]; | |||
| result[`${key}.${suffix}`] = hash[suffix]!; | |||
There was a problem hiding this comment.
we can check that hash[suffix] is not undefined as well
addon/macros/t.ts
Outdated
| @@ -15,7 +15,7 @@ function partitionDynamicValuesAndStaticValues(options: Record<string, string | | |||
| if (value instanceof Raw) { | |||
| staticValues[key] = value.valueOf(); | |||
| } else { | |||
| dynamicValues[key] = value; | |||
| dynamicValues[key] = value!; | |||
BarryThePenguin
force-pushed
the
typescript
branch
from
cb214b0
to
329fc52
Compare
|
Thanks a lot for your contributions! |
I fixed the
noUncheckedIndexedAccessissues with the non-null assertion operator.Fixing these issues in a different way would change the behaviour of the code, so I thought it would be helpful to get others input on alternative approaches.
Fixes #1598