Skip to content

Conversation

@wagenet
Copy link
Contributor

@wagenet wagenet commented Feb 11, 2021

Before:
image
After:
image

See the fi in fish and firstObject.

@wagenet
Copy link
Contributor Author

wagenet commented Feb 11, 2021

We may want to do this in some other repos as well.

@locks locks had a problem deploying to ember-api-docs-review-t-pr-742 February 11, 2021 17:23 Failure
@jenweber jenweber self-requested a review February 12, 2021 00:32
Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Possibly our other apps are ok since they use different syntax highlighter libraries, if I remember right.

@wagenet
Copy link
Contributor Author

wagenet commented Feb 19, 2021

@jenweber what's the protocol for merging?

@locks locks merged commit ea2b224 into master Feb 26, 2021
@locks locks deleted the wagenet-patch-1 branch February 26, 2021 12:03
@locks
Copy link
Contributor

locks commented Feb 26, 2021

Boom, merged!

@jenweber
Copy link
Contributor

jenweber commented Mar 1, 2021

Thanks for the fix @wagenet! I was a little worried about the failed deploy preview. It has nothing to do with your PR, just maybe something that popped up elsewhere.

@locks did you run a deploy to production? Instructions are in DEPLOYING.md. It's been a while since I've done it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants