Support more glimmer segments

[jenweber]

Previously, @glimmer/tracking/primitives/cache was a 404. This was
because the id parsing was adding an extra "ember-" to the front of
the id.

Closes #751

Co-authored-by: Amy Lam amyrlam@users.noreply.github.com

[amyrlam]

[amyrlam]

I'll try the staging steps https://github.com/ember-learn/ember-api-docs/blob/master/DEPLOYING.md#deploying-to-stagingtest-environment and looks like #742 will be a part of it. Will report back here

[amyrlam]

@jenweber I am unable to deploy to staging. There's an error about node v16.1.0 in the "Review Apps" column for this PR 755, which seems strange, as that version exists. Am wondering if deploying to prod, even without checking staging, will have the same problem?

• It seems like we should update Review Apps "Upgrade this pipeline" button on the LHS. I didn't do that yet cause figured should check with you as haven't been in Heroku much. Can contact Heroku support if have the issue again?
• Prod hasn't been deployed since June 2020 so ligatures PR and others can go out with this one to prod.

[amyrlam]

Updated review apps in Heroku, but now getting this:

We have the config var here:

ember-api-docs/app.json

Line 12 in de2a794

"HEROKU_EMBER_CLI_DEPLOY": {

Will try xposting in #core-learning / sent Heroku a ticket.

[amyrlam]

I pushed some commits trying to see if would fix Heroku review apps. @sivakumar-kailasam or @locks do you know? Saw your pics in Heroku.

If we need HEROKU_EMBER_CLI_DEPLOY env var, what should it be set as in Heroku? I couldn't figure out what addon this was from? I posted the ticket here https://discord.com/channels/480462759797063690/480794014375870475/841125709392773140 but am not sure what to ask next TBH.

[sivakumar-kailasam]

Sorry @amyrlam its been a long while since I've looked into this codebase, so don't remember it all that well 😅. Have you tried setting it to true? (I don't have heroku access anymore so couldn't look at that either).

[amyrlam]

@sivakumar-kailasam No worries, thanks for replying! It was set to true before on this branch / on master. I actually couldn't figure out what addon it's from.

[sivakumar-kailasam]

its probably for the heroku buildpack but i could be wrong 🙂

[amyrlam]

Merging this and extracting out Heroku to #758.

[amyrlam]

@sivakumar-kailasam thank you, yes, from Chris and Locks at the meeting, it is exactly that, le sigh. Extracted out Heroku debugging to #758. We talked about it at the meeting emberjs/core-notes#382 and Chris / Locks are going to meet on it next week to see if there is a solution...