From f061b132952b9612d13ba11f924e745e4ebe99d1 Mon Sep 17 00:00:00 2001 From: Amy Lam Date: Tue, 11 May 2021 19:14:22 -0700 Subject: [PATCH 1/5] Change app variable to false Don't think this is required, will see if it works on the Heroku dashboard --- app.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.json b/app.json index 74bf005d0..43fb83137 100644 --- a/app.json +++ b/app.json @@ -10,7 +10,7 @@ "required": false }, "HEROKU_EMBER_CLI_DEPLOY": { - "required": true + "required": false }, "WORKER_COUNT": { "required": false From d8e975ac3506b0f0c6ff9a76b33e3dfe063b6dfc Mon Sep 17 00:00:00 2001 From: Amy Lam Date: Tue, 11 May 2021 19:24:20 -0700 Subject: [PATCH 2/5] Update package values Error message in Heroku: "Unable to download node 16.1.0; does it exist?" --- package.json | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/package.json b/package.json index 83bc47118..658f8a52b 100644 --- a/package.json +++ b/package.json @@ -107,8 +107,8 @@ }, "engines": { "node": "10.* || >= 12", - "npm": "5", - "yarn": "^1.22.0" + "npm": "7", + "yarn": "1.22.10" }, "ember": { "edition": "octane" @@ -123,7 +123,7 @@ "abortcontroller-polyfill/dist/cjs-ponyfill" ], "volta": { - "node": "12.16.1", - "yarn": "1.22.4" + "node": "14.17.0", + "yarn": "1.22.10" } } From 23212aeca66d2aab82ac743210d61fbfc09b6a3c Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 13 May 2021 17:05:18 +0100 Subject: [PATCH 3/5] update buildpack --- app.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app.json b/app.json index 43fb83137..33906b7b0 100644 --- a/app.json +++ b/app.json @@ -22,7 +22,7 @@ ], "buildpacks": [ { - "url": "https://codon-buildpacks.s3.amazonaws.com/buildpacks/heroku/emberjs.tgz" + "url": "https://buildpack-registry.s3.amazonaws.com/buildpacks/aedev/emberjs.tgz" } ] } From 7003577967f62ebe69202c356f6245e3b1275ed7 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 13 May 2021 17:09:17 +0100 Subject: [PATCH 4/5] use modern heroku stack --- app.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app.json b/app.json index 33906b7b0..ec1d4409a 100644 --- a/app.json +++ b/app.json @@ -24,5 +24,6 @@ { "url": "https://buildpack-registry.s3.amazonaws.com/buildpacks/aedev/emberjs.tgz" } - ] + ], + "stack": "heroku-20" } From 48314ffb9e33379892257c9ffd40daddd3ae65f0 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Thu, 13 May 2021 17:32:50 +0100 Subject: [PATCH 5/5] prevent node 16 from being installed in heroku --- package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package.json b/package.json index 658f8a52b..e9d9d4161 100644 --- a/package.json +++ b/package.json @@ -106,7 +106,7 @@ "testem": "^2.14.0" }, "engines": { - "node": "10.* || >= 12", + "node": "10.* || 12.* || 14.*", "npm": "7", "yarn": "1.22.10" },