Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2019-12-02-countdown-to-the-new-year-ember-cli-mirage.md #377

Merged
merged 7 commits into from Dec 2, 2019

Conversation

@MelSumner
Copy link
Member

MelSumner commented Nov 25, 2019

When merged, this will create a new blog post for the DecEmber 2019 blog series.

Should be merged on December 2nd, 2019.

Resolves #366

When merged, this will create a new blog post for the DecEmber 2019 blog series. Should be merged on December 2nd, 2019.
@MelSumner MelSumner added this to In progress in DecEmber 2019 blog post series via automation Nov 25, 2019
@MelSumner MelSumner added the decEmber label Nov 25, 2019
Copy link
Contributor

jessica-jordan left a comment

This reads great! I left one more suggestion - let me know what you think!

MelSumner and others added 3 commits Dec 2, 2019
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
Co-Authored-By: Ricardo Mendes <rokusu@gmail.com>
DecEmber 2019 blog post series automation moved this from In progress to Reviewer approved Dec 2, 2019
Copy link
Contributor

jessica-jordan left a comment

This reads great! Thank you for another December writeup this week!

@amyrlam

This comment has been minimized.

Copy link
Member

amyrlam commented Dec 2, 2019

Content lgtm!

I added a change to the template and Dec 1st, if you want to include it: #396

Adding the READMORE in the correct spot.
@MelSumner MelSumner merged commit 782ead1 into master Dec 2, 2019
7 checks passed
7 checks passed
Header rules - ember-blog-legacy No header rules processed
Details
Pages changed - ember-blog-legacy 12 new files uploaded
Details
Redirect rules - ember-blog-legacy No redirect rules processed
Details
Mixed content - ember-blog-legacy No mixed content detected
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
netlify/ember-blog-legacy/deploy-preview Deploy preview ready!
Details
DecEmber 2019 blog post series automation moved this from Reviewer approved to Done Dec 2, 2019
@MelSumner MelSumner deleted the feature/issue-366 branch Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
You can’t perform that action at this time.