Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember-accessibility #1030

Open
wants to merge 1 commit into
base: master
from

Conversation

@astronomersiva
Copy link

commented Aug 31, 2019

No description provided.

@MelSumner MelSumner self-requested a review Sep 1, 2019
@MelSumner

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

Hi! Can you tell me how this differs from ember-a11y-testing?

@jenweber

This comment has been minimized.

@astronomersiva

This comment has been minimized.

Copy link
Author

commented Sep 1, 2019

Hello @MelSumner,

Like given in the link provided by @jenweber, this addon is mostly geared towards helping with development rather than the testing phase. They both use Axe under the hood but ember-accessibility provides directly addressable feedback. We have found it useful in our large team as people just have to click on the accessibility violation indicator and the addon tells how to fix that issue.

Here's an example.

Screen Shot 2019-09-01 at 21 16 22

Also, both addons have test helpers in case that's relevant.

@MelSumner

This comment has been minimized.

Copy link
Member

commented Sep 1, 2019

@astronomersiva ahh okay. I'd like to check the addon out first and make sure that it's accessible. Also, could you help me understand why a separate addon was created instead of the typical community approach of contributing to an addon that already existed to do the same thing? Thanks!

@jenweber

This comment has been minimized.

Copy link
Contributor

commented Sep 12, 2019

@MelSumner have you had a chance to look this over? Thanks!

@jenweber

This comment has been minimized.

Copy link
Contributor

commented Oct 2, 2019

Just to share an update, this PR is remaining open because I think there are some checks that need to happen to make sure the addon itself is accessible. Hover states are tricky. With Octane coming down the line, this is on the backburner for the next few weeks, but we'll come back to it. Thanks for your patience!

@jenweber jenweber added the on hold label Oct 2, 2019
@astronomersiva

This comment has been minimized.

Copy link
Author

commented Oct 4, 2019

Appreciate the update @jenweber. I'll also take a look at the addon over the weekend and see if we've missed something.

To answer @MelSumner's question(apologies for missing it), what this addon does would have required a pretty significant rewrite of the ember-a11y-testing addon.To be frank it was quite simpler to just write something from the ground up. While the addon itself might lack accessibility in a few cases (we intend to evaluate and fix it over the next few days), we have used it on our apps in a team of a about forty developers and what we all loved was how simple the fixes were thanks to the context provided.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.