Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the edition guide to match the latest changes #1062

Merged
merged 7 commits into from Sep 15, 2019

Conversation

@pzuraq
Copy link
Contributor

commented Sep 11, 2019

This updates the edition guide with a general editting pass,
and to make sure that all of the information within it is
accurate with the latest changes (e.g. tracked property
interop has changed slightly)

@pzuraq pzuraq force-pushed the update-edition-guide-to-latest branch from e1f8119 to 8cf83e7 Sep 11, 2019
This updates the edition guide with a general editting pass,
and to make sure that all of the information within it is
accurate with the latest changes (e.g. tracked property
interop has changed slightly)
@pzuraq pzuraq force-pushed the update-edition-guide-to-latest branch from 8cf83e7 to 0ced899 Sep 11, 2019
Co-Authored-By: Ilya Radchenko <knownasilya@gmail.com>
Co-Authored-By: Ilya Radchenko <knownasilya@gmail.com>
`constructor`, so you can generally convert to native class syntax without
rewriting your `init` methods. However, in the future `init` will be removed,
so you should eventually transition to `constructor`.

This comment has been minimized.

Copy link
@knownasilya

knownasilya Sep 11, 2019

Contributor

Should @classic be mentioned?

This comment has been minimized.

Copy link
@pzuraq

pzuraq Sep 13, 2019

Author Contributor

Possibly, I think it'd be best to add in a followup though

available in JavaScript, mixins gave Ember developers some powers that are
similar to class inheritance. For apps that use mixins, the recommended path is
to refactor the ixins to be native classes instead, which the other parts of
your app can inherit from.

This comment has been minimized.

Copy link
@knownasilya

knownasilya Sep 11, 2019

Contributor

Also worth mentioning using container/provider component patterns.

They can be thought of as _functional_ components, in the sense that their
output (the rendered template) is a pure function of their inputs (their
arguments). The fact that they can't have state makes them much easier to reason
about in general, and less prone to errors.

This comment has been minimized.

Copy link
@knownasilya

knownasilya Sep 11, 2019

Contributor

probably worth mentioning that @args are what you would use

pzuraq and others added 3 commits Sep 13, 2019
Co-Authored-By: Ilya Radchenko <knownasilya@gmail.com>
@jenweber

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Just some spellchecks to clean up:

guides/release/upgrading/editions.md
626 1147:12-1147:23 warning Componentts is misspelt; did you mean Components, COMPONENT'S? retext-spell retext-spell
627 1192:25-1192:42 warning 2-way-databinding is misspelt retext-spell retext-spell

guides/release/upgrading/editions.md Outdated Show resolved Hide resolved
guides/release/upgrading/editions.md Outdated Show resolved Hide resolved
@jenweber

This comment has been minimized.

Copy link
Contributor

commented Sep 15, 2019

Thank you @pzuraq and @knownasilya for your work on this!

@jenweber jenweber merged commit 0fc88af into octane Sep 15, 2019
5 of 7 checks passed
5 of 7 checks passed
Header rules - ember-guides No header rules processed
Details
Pages changed - ember-guides 3650 new files uploaded
Details
Mixed content - ember-guides No mixed content detected
Details
Redirect rules - ember-guides 2 redirect rules processed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ember-guides/deploy-preview Deploy preview ready!
Details
percy/guides-app Visual review approved by Jen Weber
Details
@jenweber jenweber deleted the update-edition-guide-to-latest branch Sep 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.