Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Update ember data guides to use @ember-data packages #814

Open
wants to merge 7 commits into
base: master
from

Conversation

@bmac
Copy link

commented May 25, 2019

No description provided.

@jenweber

This comment has been minimized.

Copy link
Contributor

commented May 30, 2019

Thank you so much @bmac!

Notes to maintainers - the gameplan here is that for 3.11, we cut a release of the Guides, and then merge this in immediately so it shows up for 3.11 users but not 3.10. I added a label and an issue to help remind us #825

@jenweber jenweber changed the title Update ember data guides to use @ember-data packages Update ember data guides to use @ember-data packages - WIP for 3.11 May 30, 2019
@jenweber jenweber changed the title Update ember data guides to use @ember-data packages - WIP for 3.11 [3.11] Update ember data guides to use @ember-data packages - WIP May 30, 2019
@jenweber jenweber changed the title [3.11] Update ember data guides to use @ember-data packages - WIP [3.11] Update ember data guides to use @ember-data packages May 30, 2019
@jenweber jenweber added the on hold label May 30, 2019
@locks

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

@jenweber we can do both in this PR because we need a commit creating the 3.10 folder, right?

@locks locks force-pushed the bmac:update-model-guides branch from fa92f80 to b18b78d Jun 28, 2019
@locks

This comment has been minimized.

Copy link
Contributor

commented Jun 28, 2019

Rebased to resolve conflicts.

@jenweber

This comment has been minimized.

Copy link
Contributor

commented Aug 20, 2019

We can update, re-review, and merge, when the generators match the style of this PR. The generators currently produce:

import DS from 'ember-data';
const { Model } = DS;

export default Model.extend({

});

I'm marking this PR as WIP. Please let us know when we should take another look!

@jenweber jenweber changed the title [3.11] Update ember data guides to use @ember-data packages WIP - Update ember data guides to use @ember-data packages Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.