Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated **Testing** for Octane documentation #964

Merged
merged 4 commits into from Aug 27, 2019

Conversation

@ijlee2
Copy link

commented Jul 30, 2019

This PR completes several, but not all, tasks that were discussed in issue #458. I plan to make additional PRs to finish the remaining tasks for this issue.

In particular, I made changes to the Introduction page by moving around existing content and adding more content. I also created the Different Types of Tests page to compare and contrast unit, rendering, and application tests.

@toddjordan

This comment has been minimized.

Copy link
Contributor

commented Aug 1, 2019

@ijlee2 Thanks for submitting this! I'll be looking at it today and tomorrow and will provide feedback.

@ijlee2

This comment has been minimized.

Copy link
Author

commented Aug 1, 2019

@toddjordan, thank you for your time and feedback in advance!

Updated Testing by (1) rewriting Introduction (moved existing content…
… around and added more content) and (2) creating Different Types of Tests

@ijlee2 ijlee2 force-pushed the ijlee2:octane-il-07272019 branch from 5f78d99 to f00cc6b Aug 5, 2019

guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
@ijlee2

This comment has been minimized.

Copy link
Author

commented Aug 5, 2019

@toddjordan, thanks for your feedback. I will work on applying it soon (I should be able to do by Wednesday the 7th).

Cheers,

@ijlee2 ijlee2 force-pushed the ijlee2:octane-il-07272019 branch from 2cdd55f to 26c4549 Aug 6, 2019

@ijlee2 ijlee2 force-pushed the ijlee2:octane-il-07272019 branch from 26c4549 to a6f62e7 Aug 6, 2019

@ijlee2

This comment has been minimized.

Copy link
Author

commented Aug 6, 2019

Todd, I've updated Introduction and Different Types of Tests pages. Would you mind taking a look at them once more?

@toddjordan

This comment has been minimized.

Copy link
Contributor

commented Aug 8, 2019

Thanks @ijlee2 for the updates, I'll take another pass on Friday/over the weekend.

@toddjordan

This comment has been minimized.

Copy link
Contributor

commented Aug 14, 2019

Sorry for the delay. Planning on looking at it today.

guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
guides/release/testing/different-types-of-tests.md Outdated Show resolved Hide resolved
@ijlee2

This comment has been minimized.

Copy link
Author

commented Aug 16, 2019

Thanks, @toddjordan. I will work on it today, if not tomorrow.

Cheers,

@ijlee2 ijlee2 force-pushed the ijlee2:octane-il-07272019 branch from fd60f6a to a6fb95f Aug 18, 2019

@jenweber

This comment has been minimized.

Copy link
Contributor

commented Aug 22, 2019

I would like to merge this, and if additional work is needed, it could continue on another branch and a new PR. Does that work ok?

@ijlee2

This comment has been minimized.

Copy link
Author

commented Aug 22, 2019

@jenweber I'm cool with it. Todd and I were waiting for another team member to review.

@toddjordan

This comment has been minimized.

Copy link
Contributor

commented Aug 26, 2019

I'm going to target this week for merge and put one last reminder today. I put it out to the learning team but no takers so far (folks get busy).

guides/release/pages.yml Outdated Show resolved Hide resolved
@jenweber

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

I have noticed a couple teeny things in my readthrough but this is at MVP and we should ship it 🎉

The build failed due to an unrelated timeout. I ran it again and it seems fine.

@jenweber jenweber merged commit dd14a57 into ember-learn:octane Aug 27, 2019

5 of 7 checks passed

Header rules - ember-guides No header rules processed
Details
Pages changed - ember-guides 3668 new files uploaded
Details
Mixed content - ember-guides No mixed content detected
Details
Redirect rules - ember-guides 2 redirect rules processed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
netlify/ember-guides/deploy-preview Deploy preview ready!
Details
percy/guides-app Visual review approved by Jen Weber
Details
@jenweber

This comment has been minimized.

Copy link
Contributor

commented Aug 27, 2019

Thanks again @ijlee2 and @toddjordan for your work on this!!! I especially love the "three kinds of tests" summary.

@jessica-jordan jessica-jordan referenced this pull request Aug 27, 2019
6 of 8 tasks complete

@ijlee2 ijlee2 deleted the ijlee2:octane-il-07272019 branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.