Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build super-rentals using Octane Edition #127

Merged
merged 6 commits into from Jul 1, 2019

Conversation

@vaidehijoshi
Copy link

commented Jun 21, 2019

This PR upgrades the super-rentals tutorial app by re-building the app using idiomatic Ember for the Octane edition. I paired with @wycats to work through the tutorial, upgrading to Octane along the way, as we built the app from scratch.

馃殾There is one pending TODO here before this can be merged:

  • I'm waiting on ember-data to release a canary with this commit so that I can point to it in our package.json and generate a yarn.lock from that. Currently, the package.json points to a local tarball file of ember-data that we used locally, but that was just a stop-gap. 馃槵 Once the canary is released, I'll update that and note it here.

馃摑 Two other points to note:

  • While pairing with @wycats, he suggested we use ember-functional-modifiers to write a modifier.
  • Some of the diffs here remove tests (see the routes tests). We built this app directly from the tutorial, so those diffs indicate to me that the prose of the tutorial no longer includes these tests, but the tutorial code itself wasn't update, which is why the diff appears.

jenweber and others added some commits May 28, 2019

Merge pull request #125 from ember-learn/update-leaflet
use leaflet maps version that doesn't need jquery #124
Merge pull request #126 from DPK101/patch-1
Update to keep in sync with ember cli (3.10.1) command generated code

@vaidehijoshi vaidehijoshi marked this pull request as ready for review Jun 21, 2019

@vaidehijoshi vaidehijoshi referenced this pull request Jun 21, 2019
Use ember-data canary [3.12.0-canary.1]
Do this so that we can rely on this commit:
emberjs/data@cf399b2

@jenweber jenweber merged commit 88adfc7 into ember-learn:octane Jul 1, 2019

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

@vaidehijoshi vaidehijoshi deleted the vaidehijoshi:octane-edition branch Jul 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.