Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint and test failures in Octane branch #129

merged 7 commits into from Jul 1, 2019


Copy link

commented Jul 1, 2019

This PR fixes some problems with the initial conversion to Octane:

  1. Fixes JavaScript linting errors by configuring eslint to use babel-eslint, and configuring Babel to enable support for decorators and class fields.
  2. Fixes a formatting issue causing the template lint to fail.
  3. Removes the package-lock.json file that was mistakenly checked in (the project already had a yarn.lock file).
  4. Enables the EMBER_METAL_TRACKED_PROPERTIES feature flag in Ember canary, the lack of which was causing the test suite to fail.
  5. Sets the jquery-integration optional feature to false to silence the deprecation warning emitted during builds.
  6. Upgrades the Node.js version from 6 to 8 in the Travis config.

@tomdale tomdale added the octane label Jul 1, 2019

@tomdale tomdale requested review from wycats, toddjordan and jenweber Jul 1, 2019

@jenweber jenweber merged commit cb39b4c into octane Jul 1, 2019

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build is in progress
continuous-integration/travis-ci/pr The Travis CI build passed

@tomdale tomdale deleted the octane-fix-lints branch Jul 1, 2019

@wycats wycats removed their request for review Jul 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.