From 975758ae1295e1441cf37dfb91b6e43038ddb431 Mon Sep 17 00:00:00 2001 From: Chris Manson Date: Mon, 17 Jun 2024 17:58:00 +0100 Subject: [PATCH] add notes for learning 17th June --- learning-team/2024/2024-06-17.md | 52 ++++++++++++++++++++++++++++++++ learning-team/template.md | 28 +++-------------- 2 files changed, 57 insertions(+), 23 deletions(-) create mode 100644 learning-team/2024/2024-06-17.md diff --git a/learning-team/2024/2024-06-17.md b/learning-team/2024/2024-06-17.md new file mode 100644 index 00000000..c1e74b7a --- /dev/null +++ b/learning-team/2024/2024-06-17.md @@ -0,0 +1,52 @@ +# 2024-06-17 + +Note Taker: Chris Manson +Time Keeper: Anne-Greeth Schot-van Herwijnen + +## Attendees + +Add yourself to the list if you attend and check the box! + +### Core Team + +- [x] Chris Manson (CM) +- [x] Jared Galanis (JG) +- [ ] Jen Weber (JW) +- [ ] Ricardo Mendes (RM) +- [ ] Robert Wagner (RW) +- [x] Anne-Greeth Schot-van Herwijnen (AG) +- [x] Ignace Maes (IM) + +## Topics + +### Feature Flag / Toggle <@jaredgalanis> + +- https://github.com/ember-learn/guidemaker-ember-template/pull/191 + +- JG: discussion about feature flags +- IM: basic implementaion is imporant +- then we can start using it for other things like template tags +- JS vs TS is another discussion +- should we have switches per code block or globally +- CM: I think we talked about needing surrounding blurbs +- that way we shouldn't be +- IM: we need to unblock polaris docs, we can get people to start contributing +- CM: assuming the tech part is done, how do we deal with multiple toggles at the same time? polaris and typescript +- do we need 4 versions of the docs? +- CM: we need to be clear about the point of the feature flag +- it is intended to be a mechanism to preview the new guides +- (discussion about the feature flag) +- (description of CM's idea of how the toggle will exactly work) +- Action Item: CM to write down the exact plan so get everyone in the core teams can agree on the plan +- (discussion about sub-flags) + +### Deprecations PR from Katie/Nullvox <@jaredgalanis> + +- https://github.com/ember-learn/deprecation-app/pull/1383 +- CM: I don't think this is highest priority, I don't think we should complicate the data structure of the deprecations +- (general discussion) +- (general agreement that we don't need to merge the PR to get https://github.com/ember-learn/deprecation-app/pull/1381 merged) +- JG: devil's advocate - we have been slow on making changes to the website so delaying merging the deprecation PR because of a new layout +- CM: I'm not saying to not merge the deprecation PR, I think it's fine +- (discussion about performance of the app) +- AG will respond to the PR \ No newline at end of file diff --git a/learning-team/template.md b/learning-team/template.md index 22b199ac..79fb309c 100644 --- a/learning-team/template.md +++ b/learning-team/template.md @@ -1,6 +1,7 @@ -# Month Day, Year +# YYYY-MM-DD -Facilitator & Note Taker: +Note Taker: +Time Keeper: ## Attendees @@ -16,28 +17,9 @@ Add yourself to the list if you attend and check the box! - [ ] Chris Ng (CN) - [ ] Anne-Greeth Schot-van Herwijnen (AG) - [ ] Ignace Maes (IM) - -### Guests - -- [] Your name here (INITIALS) - -## Weekly review (10 mins) - -[Open pull requests](https://help-wanted.emberjs.com/pull-requests) - -[RFC review app](https://rfcs.emberjs.com/) - -[RFC PR Queue](https://github.com/emberjs/rfcs/pulls) +- [ ] Guest name here (INITIALS) ## Topics - - -## Ember Times suggestions - -Add writeup ideas / call for contributors / suggestions to [the latest PR](https://github.com/ember-learn/ember-blog/pulls?q=is%3Aopen+is%3Apr+label%3A%22%F0%9F%97%9E+embertimes%22%20or%20#support-ember-times) or [#support-ember-times](https://discordapp.com/channels/480462759797063690/485450546887786506) on Discord. - -## Any Questions? - -Questions, comments or concerns? Submit a comment or PR for this set of notes. + \ No newline at end of file