Skip to content

changesToSync not populating correctly #582

Closed
bradleypriest opened this Issue Jan 6, 2013 · 2 comments

4 participants

@bradleypriest
Ember.js member

From commit e493b10, L187 and L194 of lib/system/model/states.js use context.attributeName, however no attributeName is passed in where it is called here

I think this should be just name.

I can't seem to put together a failing testcase, but _changesToSync has one entry with a key of undefined when making multiple changes.

@wycats
Ember.js member
wycats commented Jan 6, 2013

@IgorT Thoughts?

@workmanw

I too have noticed this problem. I'm not sure if attributeName is intended to be used, if so the key might need to be converted to attributeName. Either way, it would be nice to get this one fixed up.

@jetako jetako added a commit to jetako/ember-data that referenced this issue Feb 7, 2013
@jetako jetako fixed issue #582 d5cb073
@igorT igorT closed this Apr 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.