The owner record is now an argument passed to findMany on the adapter #625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here is the original issue #573 |
|
|
||
| var person = store.find(Person, 1); | ||
|
|
||
| equal(get(person, 'isLoaded'), true, "isLoaded should be false"); |
While writing an adapter for my django backend I was unable to build a valid url for my hasMany relationships because the owner was not easily accessible. Going forward the owner will now be an argument available for custom adapters like the one I ended up writing. example of how my REST api would lookup hasMany relationships: If I have a person with many occupations I would look them up like so /people/1/occupations/ Notice the id 1 above is actually the owner of the occupations (not a occupation id from the ids array that is passed into findMany) Instead of passing each id like the built in RESTAdapter the url above just expects the owner will know how to find each occupation
|
I had a few assertions with the incorrect error message -I fixed this and pushed that change back up |
wycats
added a commit
that referenced
this pull request
Jan 15, 2013
The owner record is now an argument passed to findMany on the adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While writing an adapter for my django backend I was unable to
build a valid url for my hasMany relationships because the owner
was not easily accessible. Going forward the owner will now be an
argument available for custom adapters like the one I ended up writing.
example of how my REST api would lookup hasMany relationships:
If I have a person with many occupations I would look them up like so
/people/1/occupations/
Notice the id 1 above is actually the owner of the occupations (not a
occupation id from the ids array that is passed into findMany)
Instead of passing each id like the built in RESTAdapter the url above
just expects the owner will know how to find each occupation