Lots of ids in a relationship cause requests with too large URLs #804

Closed
darthdeus opened this Issue Mar 13, 2013 · 5 comments

Projects

None yet

4 participants

@darthdeus
Member

If I have a model with a relationship that contains something like this

"round_ids":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16,17,18,19,20,21,22,23,24,25,26,27,28,29,30,31,32,33,34,35,36,37,38,39,40,41,42,43,44,45,46,47,48,49,50,51,52,53,54,55,56,57,58,59,60,61,62,63,64,65,66,67,68,69,70,71,72,73,74,75,76,77,78,79,80,81,82,83,84,85,86,87,88,89,90,91,92,93,94,95,96,97,98,99,100,101,102,103,104,105,106,107,108,109,110,111,112,113,114,115,116,117,118,119,120,121,122,123,124,125,126,127,128,129,130,131,132,133,134,135,136,137,138,139,140,141,142,143,144,145,146,147,148,149,150,151,152,153,154,155,156,157,158,159,160,161,162,163,164,165,166,167,168,169,170,171,172,173,174,175,176,177,178,179,180,181,182,183,184,185,186,187,188,189,190,191,192,193,194,195,196,197,198,199,200,201,202,203,204,205,206,207,208,209,210,211,212,213,214,215,216,217,218,219,220,221,222,223,224,225,226,227,228,229,230,231,232,233,234,235,236,237,238,239,240,241,242,243,244,245,246,247,248,249,250,251,252,253,254,255,256,257,258,259,260,261,262,263,264,265,266,267,268,269,270,271,272,273,274,275,276,277,278,279,280,281,282,283,284,285,286,287,288,289,290,291,292,293,294,295,296,297,298,299,300,301,302,303,304,305,306,307,308,309,310,311,312,313,314,315,316,317,318,319,320,321,322,323,324,325,326,327,328,329,330,331,332,333,334,335,336,337,338,339,340,341,342,343,344,345,346,347,348,349,350,351,352,353,354,355,356,357,358,359,360,361,362,363,364,365,366,367,368,369,370,371,372,373,374,375,376,377,378,379,380,381,382,383,384,385,386,387,388,389,390,391,392,393,394,395,396,397,398,399,400,401,402,403,404,405,406,407,408,409,410,411,412,413,414,415,416,417,418,419,420,421,422,423,424,425,426,427,428,429,430,431,432,433,434,435,436,437,438,439,440,441,442,443,444,445,446,447,448,449,450,451,452,453,454,455,456,457,458,459,460,461,462,463,464,465,466,467,468,469,470,471,472,473,474,475,476,477,478,479,480,481,482,483,484,485,486,487,488,489,490,491,492,493,494,495,496,497,498,499,500]

it will cause one huge request which looks like

http://example.com/rounds?ids%5B%5D=1&ids%5B%5D=2&ids%5B%5D=3&ids%5B%5D=4&ids%5B%5D=5&ids%5B%5D=6&ids%5B%5D=7&ids%5B%5D=8&ids%5B%5D=9&ids%5B%5D=10&ids%5B%5D=11&ids%5B%5D=12&ids%5B%5D=13&ids%5B%5D=14&ids%5B%5D=15&ids%5B%5D=16&ids%5B%5D=17&ids%5B%5D=18&ids%5B%5D=19&ids%5B%5D=20&ids%5B%5D=21&ids%5B%5D=22&ids%5B%5D=23&ids%5B%5D=24&ids%5B%5D=25&ids%5B%5D=26&ids%5B%5D=27&ids%5B%5D=28&ids%5B%5D=29&ids%5B%5D=30&ids%5B%5D=31&ids%5B%5D=32&ids%5B%5D=33&ids%5B%5D=34&ids%5B%5D=35&...

which will fail because the URI is too long. There should be an option to specify maximum length of URI and split this into multiple requests.

Here's a JSBin. It's not failing because apiary.io doesn't care about the URI length, but most servers will error if it's more than 255 characters.

Contributor

I haven't personally tested it out, but #531 may solve this. Also related: #651

Owner
igorT commented Apr 15, 2013

Closing as a duplicate of #651

@igorT igorT closed this Apr 15, 2013

@igorT I don't understand how #651 solves this issue? Also #531 was just closed without any fix... I'm currently trying to load a couple hundred IDs in my app and it'd be really sweet to be able to batch them. Much better than just not working at all.

@igorT Actually, soz... after having throught it through a bit more, I realise how having a separate link for groups of associated side-loaded values would/should solve this issue. :)

So there's a bug that causes links to not work for me (I think it's addressed/fixed by #1791)... which also means not having a pagination solution for #651 (which could be possibly dealt with by #1517) causes my app to just pretty much spit the 404 dummy (ie request malformed because of too many ids=?? values on the URL). Funtimes. I can realise the rationale behind #651 is good and everything, but it feels a bit like like it's a bug leaving ember ABLE to load more objects than can fit on a single URL request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment