createManyArray of store.js should be migrated to use references #806

juan77 opened this Issue Mar 14, 2013 · 1 comment


None yet

3 participants


createManyArray received clientIds before, but now receives references, so it should be updated, and would also have to register the array with registerRecordArray, so is '@each' friendly.

createManyArray: function(type, references) {
    var array = DS.ManyArray.create({ type: type, content: references, store: this });

    references.forEach(function(reference) {
      var recordArrays = this.recordArraysForClientId(reference.clientId);
    }, this);

    this.registerRecordArray(array, type);

    return array;
Ember.js member

I think this has been fixed in master. @tomdale / @stefanpenner should probably close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment