Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

deleteRecord for relationships is broken in latest master #836

Closed
BowlingX opened this Issue Mar 26, 2013 · 1 comment

Comments

Projects
None yet
2 participants

After updating to latest master deleteRecord seems not to work anymore, record is successfully deleted by server but not removed from local array after committing.

I found it this commit is causing this:
53e14dd#L1R143

if you remove the line, it work's again.

My Use-Case:

removeFavorite: function (forum, fullModel) {
        var mainModel = this.get("controllers.application").get('model');
        var fav = mainModel.get('favorites').find(function (e) {
            return e.get("id") == fullModel.get('favorite_id');
        });
        if (fav) {
            fav.deleteRecord();
            fav.get('transaction').commit();
            fav.one('didDelete', function () {
                fullModel.set('favorite_id', null);
            });
        }

    }
Owner

igorT commented Apr 5, 2013

This should be fixed on the latest master.

@igorT igorT closed this Apr 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment