Latest build appears to be broken(?) #837

Closed
sgharms opened this Issue Mar 27, 2013 · 13 comments

Comments

Projects
None yet
10 participants

sgharms commented Mar 27, 2013

I was trying to build a toy app to test things out. Per @trek's in-development guide I have the following files loading up:

    script src='/javascripts/vendor/jquery.js'
    script src='/javascripts/vendor/handlebars.js'
    script src='/javascripts/vendor/ember-1.0.0-rc.1.js'
    script src='/javascripts/vendor/ember-data.js'

On page load, data is throwing:

Uncaught TypeError: Object [object Object] has no method 'readOnly'

at

var retrieveFromCurrentState = Ember.computed(function(key, value) {
  return get(get(this, 'stateManager.currentState'), key);
}).property('stateManager.currentState').readOnly();

This build was the result of running rake dist on 9d6686cf1366bd1fd42b53d55377e2beeb546d8e. Let me also hasten to add that the Ember App has not been developed at this point. There is no router, no declaration of models. I just wanted to get the dependencies loaded successfully.

sgharms commented Mar 27, 2013

DEBUG: ------------------------------- ember-1.0.0-rc.1.js:339
DEBUG: Ember.VERSION : 1.0.0-rc.1 ember-1.0.0-rc.1.js:339
DEBUG: Handlebars.VERSION : 1.0.0-rc.3 ember-1.0.0-rc.1.js:339
DEBUG: jQuery.VERSION : 1.9.1 ember-1.0.0-rc.1.js:339
DEBUG: ------------------------------- 

Version info

Member

pangratz commented Mar 27, 2013

The readOnly is available in Ember since commit emberjs/ember.js@bb5d588. So you can either use a master build of Ember.js or you build an Ember-Data version before commit 7579054 ...

I hope this resolves your issue ...

sgharms commented Mar 27, 2013

Danke, Clemens. Very helpful.

Here's my question (open to @trek, @tomdale, @wycats, et al.): I'm a
fairly-experienced Ember user and I fell into this pit, is there some means
for people (attempting to) adopt Ember + Data or for those entirely new to
the Ember ecosystem to avoid this? I know @trek is busting his Trekkiness
trying to ameliorate the "Ember is hard to bootstrap" meme and this seems
to be a warning that all is not right.

On Wed, Mar 27, 2013 at 2:50 AM, Clemens Müller notifications@github.comwrote:

The readOnly is available in Ember since commit emberjs/ember.js@bb5d588emberjs/ember.js@bb5d588.
So you either use a master build of Ember.js or you build an Ember-Data
version before commit 75790547579054...


Reply to this email directly or view it on GitHubhttps://github.com/emberjs/data/issues/837#issuecomment-15513892
.

Owner

krisselden commented Mar 27, 2013

What would have helped you to avoid this?

sgharms commented Mar 27, 2013

Ember Data having a stated requirement on Ember
emberjs/ember.js@bb5d588emberjs/ember.js@bb5d588?
A version check? A tag check? Something like that?

On Wed, Mar 27, 2013 at 9:51 AM, Kristofor Selden
notifications@github.comwrote:

What would have help you to avoid this?


Reply to this email directly or view it on GitHubhttps://github.com/emberjs/data/issues/837#issuecomment-15535597
.

jonbca commented Mar 28, 2013

I may be mistaken (likely mistaken) but I thought that with the emberjs/ember rc1 build the API was frozen. Is it therefore likely that the readOnly feature that ember-data now relies on will not be available in ember.js 1.0.0 when it's finally released?

Member

bradleypriest commented Mar 29, 2013

@jonbca They froze existing APIs, nothing says they couldn't add new ones. ReadOnly will definitely be in 1.0.0.

Owner

trek commented Mar 29, 2013

@sgharms we're working to have sane process for obtaining ember-data. This is a blocking issue for the release of the getting started guide right now.

@jonbca we promised to keep the 1.0rc from regressions so developers who (wisely) avoid unreleased software could feel confident in giving Ember.js a try without needing to make the utility/stability tradeoff that early adopters do. We'll continue to add features, often putting them behind opt-in flags (like {{control}}) but existing applications should able to drop in newer versions of Ember all the way up to 2.0 without experiencing breakage and getting bug fixes and performance enhancements.

Developers can adopt these new features at their own pace or even not at all.

I'm new to Ember (coming straight from tomdale's 30min Youtube video) and I fell straight into this pit.

jonbca commented Mar 31, 2013

Now that Ember 1.0.0rc2 has been released I think Ember Data will run correctly.

superlou commented Apr 1, 2013

I helped somebody into the pit earlier today, then fell into it myself. Updating to Ember RC2 (and then Handlebars RC3) fixes it

Contributor

bradfol commented Apr 3, 2013

According to the Travis builds, the most recent master commit that passes is 57d6c01. After that, tests on master are failing.

Owner

igorT commented Apr 5, 2013

We fixed the build.

igorT closed this Apr 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment