add 'array' attribute type to DS.Model #137
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| highestLuckyNumber: function() { | ||
| return Math.max.apply(Math, this.get('luckyNumbers')); | ||
| }.property('luckyNumbers.@each') |
There was a problem hiding this comment.
I don't know if this is the best example for an array property ...
|
Dup of #53 |
|
The problem with this implementation is that we have no mechanism for marking a record as dirty when the contents of its array changes. We think this will be very confusing to people and would introduce subtle bugs into applications using Ember Data. We're planning on tackling this problem (which is basically the same as #53) using some kind of object proxy system to notify us when changes have been made. |
|
This worked great for my needs. App.myController.set('tags', [1,2,3,4,5]), App.store.commit() and all my changes pushed to the server. |
|
okidoki |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Inspired by question of @cloke in IRC at 2012-03-05 "18:16 cloke_ with data is there a way to have one of the attributes be an array? The data from the server is just a flat array so an association seems overly complex."