Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ember assert #244

Merged
merged 4 commits into from May 7, 2012

Conversation

Projects
None yet
3 participants
Contributor

joliss commented May 6, 2012

  • Update Ember (695694ac390)

  • Replace deprecated ember_assert with Ember.assert

    This fixes all instances of the old un-namespaced ember_* functions.

  • Update TODO item

  • Update assertion stripping regex

Member

tchak commented May 6, 2012

looks like this is a duplicate of #243. Or did you found a problem with it?

Contributor

joliss commented May 6, 2012

Ah, sorry about that, I should've checked.

I actually just caught a stray TODO comment. I repushed this -- what do you think?

@joliss joliss closed this May 6, 2012

@joliss joliss reopened this May 6, 2012

@joliss joliss closed this May 6, 2012

@joliss joliss reopened this May 6, 2012

wycats added a commit that referenced this pull request May 7, 2012

@wycats wycats merged commit 0872416 into emberjs:master May 7, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment