New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending child records should be preserved when data changes. #253

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
4 participants
@ghempton
Member

ghempton commented May 11, 2012

Currently, when a transaction containing a fully new parent-child hierarchy is committed, hasMany associations are overwritten. This PR fixes this scenario.

@bradleypriest

This comment has been minimized.

Show comment
Hide comment
@bradleypriest

bradleypriest May 14, 2012

Member

Thank you so much. I spent so long assuming this was a bug in my code. Doh.

Thankfully this also handles the situation where the server's JSON representation of the parent contains an empty array of children on the initial response.

Member

bradleypriest commented May 14, 2012

Thank you so much. I spent so long assuming this was a bug in my code. Doh.

Thankfully this also handles the situation where the server's JSON representation of the parent contains an empty array of children on the initial response.

@ghempton ghempton referenced this pull request May 15, 2012

Closed

Fix all the things... #256

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Jun 21, 2012

Member

@ghempton This doesn't merge cleanly. Can you rebase?

Member

wagenet commented Jun 21, 2012

@ghempton This doesn't merge cleanly. Can you rebase?

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Oct 18, 2012

Member

We no longer have a pending state.

Member

wagenet commented Oct 18, 2012

We no longer have a pending state.

@wagenet wagenet closed this Oct 18, 2012

@sly7-7

This comment has been minimized.

Show comment
Hide comment
@sly7-7

sly7-7 Oct 18, 2012

Contributor

Agree, but I think the comment of @bradleypriest is still valuable :/

Contributor

sly7-7 commented Oct 18, 2012

Agree, but I think the comment of @bradleypriest is still valuable :/

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Oct 19, 2012

Member

@sly7-7, @bradleypriest Would you guys be interested in submitting a new PR to specifically address that case?

Member

wagenet commented Oct 19, 2012

@sly7-7, @bradleypriest Would you guys be interested in submitting a new PR to specifically address that case?

@sly7-7

This comment has been minimized.

Show comment
Hide comment
@sly7-7

sly7-7 Oct 19, 2012

Contributor

I really would like to do it, but to be honest I absolutely no idea how to do it. I think there are some issues related to this behavior (data asynchrony induced by multiple requests to server). I think I talked wy @wycats about his, and he told me they have an internal issue tracker referring this one.

Contributor

sly7-7 commented Oct 19, 2012

I really would like to do it, but to be honest I absolutely no idea how to do it. I think there are some issues related to this behavior (data asynchrony induced by multiple requests to server). I think I talked wy @wycats about his, and he told me they have an internal issue tracker referring this one.

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Oct 20, 2012

Member

@sly7-7 He's probably referring to https://www.pivotaltracker.com/projects/629735. Not sure what ticket though.

Member

wagenet commented Oct 20, 2012

@sly7-7 He's probably referring to https://www.pivotaltracker.com/projects/629735. Not sure what ticket though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment