Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code doesn't seem to match comment #2726

Closed
wants to merge 1 commit into from

Conversation

devinrhode2
Copy link

No description provided.

@bmac
Copy link
Member

bmac commented Jan 28, 2015

Hi @devinrhode2. I think the comment is poorly worded but I believe the intention was that the date transform should only return undefined if there was no value in the original json. This change makes it so that if there is a value and the value is null then the transform will convert that value to undefined which is now breaking the tests.

I don't think Ember Data is likely to accept this change as is but if you'd like to update the comment to make the intention more clear we would gladly merge that pr.

@devinrhode2
Copy link
Author

@ghempton what was the actual intention?

devinrhode2 referenced this pull request in devinrhode2/data Jan 28, 2015
@bmac
Copy link
Member

bmac commented Feb 8, 2015

Looks like @ghempton just moved that code around in that commit. The original comment came from @tomdale and @wycats in 8a812c8

bmac added a commit to bmac/data that referenced this pull request Jun 4, 2015
bmac added a commit to bmac/data that referenced this pull request Jun 4, 2015
@bmac bmac closed this in a080db4 Jun 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants