New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store.hasRecordForId should true only if a record for a given type and ID is already loaded. #2875

Merged
merged 2 commits into from Mar 22, 2015

Conversation

Projects
None yet
4 participants
@bmac
Member

bmac commented Mar 13, 2015

This pr is built on top of #2659

}
});
test("hasRecordForId should return false for records in the empty state ", function() {

This comment has been minimized.

@igorT

igorT Mar 13, 2015

Member

How about a test for true while we are at it?

@igorT

igorT Mar 13, 2015

Member

How about a test for true while we are at it?

This comment has been minimized.

@bmac

bmac Mar 13, 2015

Member

Will do

@bmac

bmac Mar 13, 2015

Member

Will do

This comment has been minimized.

@bmac

bmac Mar 13, 2015

Member

Added a test for for the true case.

@bmac

bmac Mar 13, 2015

Member

Added a test for for the true case.

bmac added a commit that referenced this pull request Mar 22, 2015

Merge pull request #2875 from bmac/has-record-for-id-loaded
Store.hasRecordForId should true only if a record for a given type and ID is already loaded.

@bmac bmac merged commit 5eef713 into emberjs:master Mar 22, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bmac bmac deleted the bmac:has-record-for-id-loaded branch Mar 22, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment