New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass _internalModel into a record when it is created #3262

Merged
merged 1 commit into from Jun 8, 2015

Conversation

Projects
None yet
2 participants
@bmac
Member

bmac commented Jun 8, 2015

Closes #3255.

@igorT

This comment has been minimized.

Member

igorT commented Jun 8, 2015

Any way we could have a test please?

@bmac

This comment has been minimized.

Member

bmac commented Jun 8, 2015

Will do

@bmac bmac force-pushed the bmac:create-internal-model branch from 6406f1f to 399f88f Jun 8, 2015

@bmac

This comment has been minimized.

Member

bmac commented Jun 8, 2015

I added a test. @igorT let me know if there is a better way to test this without directly asserting around internals.

init: function() {
this._super.apply(this, arguments);
ok(this._internalModel);

This comment has been minimized.

@igorT

igorT Jun 8, 2015

Member

ok(this.get('name')) is the thing we actually care about

This comment has been minimized.

@bmac

bmac Jun 8, 2015

Member

updated

@bmac bmac force-pushed the bmac:create-internal-model branch from 399f88f to 7bd5993 Jun 8, 2015

igorT added a commit that referenced this pull request Jun 8, 2015

Merge pull request #3262 from bmac/create-internal-model
Pass _internalModel into a record when it is created

@igorT igorT merged commit 5b4e514 into emberjs:master Jun 8, 2015

1 of 2 checks passed

continuous-integration/appveyor Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@igorT

This comment has been minimized.

Member

igorT commented Jun 8, 2015

cc @fivetanley for beta.19.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment