[BUGFIX beta] JSONSerializer.extractRelationships() issue #3736 #3747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebweaver
changed the title
sebweaver
changed the title
|
Would you be able to copy the test you modified so we're still testing with a non-existent relationship key? |
|
Both cases were indeed in the same test. For better granularity I have now splitted it into two separate tests. |
|
Appveyor build failed due to the following error: Do I have to push an empty commit to force rebuild? Or is it unnecessary? |
|
Looks good, can you squash the commits and prefix with |
…#3736 `extractRelationships` sets the undefined hasMany relationships in the same way for the belongsTo relationships, i.e. to `null`.
bmac
added a commit
that referenced
this pull request
Sep 16, 2015
[BUGFIX beta] JSONSerializer.extractRelationships() issue #3736
|
Thanks @sebweaver. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSONSerializer.extractRelationships()sets the undefined hasMany relationships in thesame way it was for the belongsTo relationships, i.e. to
null.I also enriched the corresponding test accordingly in order to cover the case.