Sideloading should respect namingConvention #384

Closed
wants to merge 1 commit into from

2 participants

@bradleypriest
Ember.js member

No description provided.

@bradleypriest
Ember.js member

I'm pretty sure sideloading doesn't respect user-specified keys either

@wagenet
Ember.js member

@bradleypriest Is this still an issue on master? If so, can you rebase?

@bradleypriest
Ember.js member

@wagenet It's still an issue, I've pushed a failing testcase for master, however with the RI stuff now the naming convention is a separate object and I can't work out how to actually fix it anymore. If anyone else wants to add a second set of eyes, I think the issue is needing to transform the name attribute here. https://github.com/emberjs/data/blob/master/packages/ember-data/lib/system/associations/ext.js#L72

@wagenet
Ember.js member

@bradleypriest, I suspect this is fixed now. If not, let us know.

@wagenet wagenet closed this Feb 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment