Use public API for container/registry when possible. #3912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @dgeb |
8 tasks
rwjblue
force-pushed
the
use-getowner
branch
2 times, most recently
from
c379df1
to
9c0d2f1
Compare
Ember 2.3 will include `Ember.getOwner` and `Ember.setOwner` as public API's to access various registry and container features. As of Ember 2.3, using `this.container` in any instance looked up from the container will issue a deprecation (instructing the user to use `Ember.getOwner(this)` instead). This PR fixes all deprecations against ember#canary channel by adding a simplified polyfill so that the internal code can always operate with the `Ember.getOwner` API.
rwjblue
force-pushed
the
use-getowner
branch
from
9c0d2f1
to
969fddc
Compare
|
Looks good to me. 👍 |
bmac
added a commit
that referenced
this pull request
Nov 11, 2015
Use public API for container/registry when possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember 2.3 will include
Ember.getOwnerandEmber.setOwneras public API's to access various registry and container features. As of Ember 2.3, usingthis.containerin any instance looked up from the container will issue a deprecation (instructing the user to useEmber.getOwner(this)instead).This PR fixes all deprecations against ember#canary channel by adding a simplified polyfill so that the internal code can always operate with the
Ember.getOwnerAPI.