New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use public API for container/registry when possible. #3912

Merged
merged 1 commit into from Nov 11, 2015

Conversation

Projects
None yet
2 participants
@rwjblue
Member

rwjblue commented Nov 10, 2015

Ember 2.3 will include Ember.getOwner and Ember.setOwner as public API's to access various registry and container features. As of Ember 2.3, using this.container in any instance looked up from the container will issue a deprecation (instructing the user to use Ember.getOwner(this) instead).

This PR fixes all deprecations against ember#canary channel by adding a simplified polyfill so that the internal code can always operate with the Ember.getOwner API.

@rwjblue

This comment has been minimized.

Show comment
Hide comment
@rwjblue
Member

rwjblue commented Nov 10, 2015

/cc @dgeb

@rwjblue rwjblue referenced this pull request Nov 10, 2015

Closed

ember-container-inject-owner - Checklist #12555

8 of 8 tasks complete
Use public API for container/registry when possible.
Ember 2.3 will include `Ember.getOwner` and `Ember.setOwner` as public
API's to access various registry and container features. As of Ember
2.3, using `this.container` in any instance looked up from the container
will issue a deprecation (instructing the user to use
`Ember.getOwner(this)` instead).

This PR fixes all deprecations against ember#canary channel by adding a
simplified polyfill so that the internal code can always operate with
the `Ember.getOwner` API.
@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Nov 11, 2015

Member

Looks good to me. 👍

Member

bmac commented Nov 11, 2015

Looks good to me. 👍

bmac added a commit that referenced this pull request Nov 11, 2015

Merge pull request #3912 from rwjblue/use-getowner
Use public API for container/registry when possible.

@bmac bmac merged commit 2e364ee into emberjs:master Nov 11, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment