New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use keyForReliationship for belongsTo and hasMany #4025

Merged
merged 1 commit into from Dec 31, 2015

Conversation

Projects
None yet
2 participants
@GCorbel
Contributor

GCorbel commented Dec 22, 2015

This PR is related to ember-data/active-model-adapter#74 .

It makes more sense to use keyForReliationship for relationships insteed of keyForAttribute.

@bmac

This comment has been minimized.

Show comment
Hide comment
@bmac

bmac Dec 22, 2015

Member

Thanks @GCorbel. Do you mind amending the commit message to start with [BUGFIX beta]?

Member

bmac commented Dec 22, 2015

Thanks @GCorbel. Do you mind amending the commit message to start with [BUGFIX beta]?

bmac added a commit that referenced this pull request Dec 31, 2015

Merge pull request #4025 from GCorbel/master
Use keyForReliationship for belongsTo and hasMany

@bmac bmac merged commit 99dec65 into emberjs:master Dec 31, 2015

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment