New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate default transforms to RESTAdapter #422

Merged
merged 1 commit into from Nov 12, 2012

Conversation

Projects
None yet
@leepfrog
Contributor

leepfrog commented Oct 17, 2012

Fixes #386, Fixes #415, Fixes #404, Fixes #206

  • Created integration test for default DS.Transforms
  • Added unit test for models for default DS.Transforms (commented out some of the tests, see #421) from: 8a812c8
  • Modified transforms.js to use DS.Transforms namespace
  • Modified transforms.js to use fromJSON/toJSON instead of to/from
  • Modified serializer to create an instance of DS.Transforms for it's default transformations instead of using the passthrough hack
  • Modified transforms.js to have a little bit of logic in boolean transform
Fixes #386, Fixes #415, Fixes #404, Fixes #206: Incorporate default t…
…ransforms to RESTAdapter

* Created integration test for default DS.Transforms
* Added unit test for models for default DS.Transforms (commented out some of the tests, see #421) from: 8a812c8
* Modified transforms.js to use DS.Transforms namespace
* Modified transforms.js to use fromJSON/toJSON instead of to/from
* Modified serializer to create an instance of DS.Transforms for it's default transformations instead of using the passthrough hack
* Modified transforms.js to have a little bit of logic in boolean transform
@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Oct 20, 2012

Member

Heh, just realized that the existing transforms.js has no use at all.

Member

wagenet commented Oct 20, 2012

Heh, just realized that the existing transforms.js has no use at all.

@daetal-us

This comment has been minimized.

Show comment
Hide comment
@daetal-us

daetal-us commented Oct 23, 2012

👍

@sohara

This comment has been minimized.

Show comment
Hide comment
@sohara

sohara commented Nov 4, 2012

👍

@pex

This comment has been minimized.

Show comment
Hide comment
@pex

pex commented Nov 5, 2012

👍

@ftokarev

This comment has been minimized.

Show comment
Hide comment
@ftokarev

ftokarev commented Nov 6, 2012

👍

@leepfrog

This comment has been minimized.

Show comment
Hide comment
@leepfrog

leepfrog Nov 6, 2012

Contributor

👍

Contributor

leepfrog commented Nov 6, 2012

👍

@bobbywilson0

This comment has been minimized.

Show comment
Hide comment
@bobbywilson0

bobbywilson0 commented Nov 6, 2012

👍

@noirbizarre

This comment has been minimized.

Show comment
Hide comment
@noirbizarre

noirbizarre commented Nov 7, 2012

👍

@pivotal-medici

This comment has been minimized.

Show comment
Hide comment
@pivotal-medici

pivotal-medici Nov 8, 2012

Contributor

👍

Contributor

pivotal-medici commented Nov 8, 2012

👍

@sgharms

This comment has been minimized.

Show comment
Hide comment
@sgharms

sgharms commented Nov 8, 2012

🔢

@xtian

This comment has been minimized.

Show comment
Hide comment
@xtian

xtian Nov 9, 2012

Contributor

👍

Contributor

xtian commented Nov 9, 2012

👍

@kevinansfield

This comment has been minimized.

Show comment
Hide comment
@kevinansfield

kevinansfield Nov 9, 2012

Contributor

👍

Contributor

kevinansfield commented Nov 9, 2012

👍

@ghempton

This comment has been minimized.

Show comment
Hide comment
@ghempton

ghempton Nov 9, 2012

Member

👍

Member

ghempton commented Nov 9, 2012

👍

@ulisesrmzroche

This comment has been minimized.

Show comment
Hide comment
@ulisesrmzroche

ulisesrmzroche commented Nov 9, 2012

+1

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Nov 11, 2012

Member

@wycats, @tomdale, any objections?

Member

wagenet commented Nov 11, 2012

@wycats, @tomdale, any objections?

wycats added a commit that referenced this pull request Nov 12, 2012

Merge pull request #422 from Mochaleaf/transforms
Incorporate default transforms to RESTAdapter

@wycats wycats merged commit 37693ce into emberjs:master Nov 12, 2012

1 check passed

default The Travis build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment