New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate normalizeHash method on the rest serializer #4258

Merged
merged 1 commit into from Mar 24, 2016

Conversation

Projects
None yet
3 participants
@bmac
Copy link
Member

bmac commented Mar 22, 2016

No description provided.

assert.expectDeprecation(function() {
env.restSerializer.normalizeResponse(env.store, HomePlanet, jsonHash, null, 'findAll');
}, /`RESTSerializer.normalizeHash` has been deprecated/)
});

This comment has been minimized.

@pangratz

pangratz Mar 22, 2016

Member

much indentation, such ocd

This comment has been minimized.

@bmac

bmac Mar 22, 2016

Author Member

Good 👀

@pangratz

This comment has been minimized.

Copy link
Member

pangratz commented Mar 22, 2016

LGTM. Let's hope this makes the cut in 3.0 😜

@bmac bmac force-pushed the bmac:deprecate-normalize-hash branch from bb220ec to f341e94 Mar 22, 2016

@bmac bmac force-pushed the bmac:deprecate-normalize-hash branch 3 times, most recently from 6fb9acc to 7936fb5 Mar 22, 2016

@bmac bmac force-pushed the bmac:deprecate-normalize-hash branch from 7936fb5 to de43c2c Mar 23, 2016

@jsangilve

This comment has been minimized.

Copy link
Contributor

jsangilve commented Mar 24, 2016

@bmac Shouldn't this remove old tests relying on normalizeHash or should they stay until 3.0?

@bmac

This comment has been minimized.

Copy link
Member Author

bmac commented Mar 24, 2016

I'd like to leave that test until 3.0 so the normalizeHash functionality doesn't regress.

@pangratz pangratz merged commit c776275 into emberjs:master Mar 24, 2016

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bmac bmac deleted the bmac:deprecate-normalize-hash branch Mar 24, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment