build ember-data attribute debug info dynamically #4640
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Nov 11, 2016
•
stefanpenner
commented
- allow other relationship types (extend the web/ember-data forward!) to be first-class and not crash the inspector
- improve tests
- restore/support humanized titles
- screenshot in inspector
- get feedback
* allow other relationship types to be first-class and not crash the inspector * improve tests
stefanpenner
force-pushed
the
enhance-attribute-debug-info
branch
from
32c4117
to
d83de4f
Compare
rwjblue
reviewed
Nov 11, 2016
| @@ -46,3 +46,83 @@ test("_debugInfo groups the attributes and relationships correctly", function(as | |||
| assert.deepEqual(propertyInfo.groups[1].properties, ['maritalStatus']); | |||
| assert.deepEqual(propertyInfo.groups[2].properties, ['posts']); | |||
| }); | |||
|
|
|||
|
|
|||
| test("_debugInfo supports arbitray relationship types", function(assert) { | |||
There was a problem hiding this comment.
small typo here, should be arbitrary
|
This looks great to me! |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.