New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate didUpdateAll, add _didUpdateAll. #4909

Merged
merged 1 commit into from Apr 5, 2017
Jump to file or symbol
Failed to load files and symbols.
+11 −6
Diff settings

Always

Just for now

@@ -105,7 +105,7 @@ const {
_setupRelationships,
adapterFor,
_buildInternalModel,
didUpdateAll,
_didUpdateAll,
modelFactoryFor,
modelFor,
normalize,
@@ -122,7 +122,7 @@ const {
'_setupRelationships',
'adapterFor',
'_buildInternalModel',
'didUpdateAll',
'_didUpdateAll',
'modelFactoryFor',
'modelFor',
'normalize',
@@ -1654,17 +1654,22 @@ Store = Service.extend({
},
/**
@method didUpdateAll
@method _didUpdateAll
@param {String} modelName
@private
*/
didUpdateAll(modelName) {
heimdall.increment(didUpdateAll);
_didUpdateAll(modelName) {
heimdall.increment(_didUpdateAll);
let liveRecordArray = this.recordArrayManager.liveRecordArrayFor(modelName);
set(liveRecordArray, 'isUpdating', false);
},
didUpdateAll(modelName) {
deprecate('didUpdateAll was documented as private and will be removed in the next version of Ember Data.');
return this._didUpdateAll(modelName);
},
/**
This method returns a filtered array that contains all of the
known records for a given type in the store.
@@ -134,7 +134,7 @@ export function _findAll(adapter, store, modelName, sinceToken, options) {
let payload = normalizeResponseHelper(serializer, store, modelClass, adapterPayload, null, 'findAll');
store._push(payload);
store.didUpdateAll(modelName);
store._didUpdateAll(modelName);
return recordArray;
}, null, 'DS: Extract payload of findAll ${modelName}');
ProTip! Use n and p to navigate between commits in a pull request.