Failing tests for RESTAdapter fails to materialize embedded belongsTo associations #523

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
@ivanvanderbyl
Contributor

ivanvanderbyl commented Dec 14, 2012

This is a failing test for #504

Basically this fails as part of the semantics of RESTSerializer are converting the belongsTo key to person_id instead of person which is the key of the embedded object.

@wagenet

This comment has been minimized.

Show comment
Hide comment
@wagenet

wagenet Jan 10, 2013

Member

@ivanvanderbyl Can you review and see if this is still an issue on master?

Member

wagenet commented Jan 10, 2013

@ivanvanderbyl Can you review and see if this is still an issue on master?

@ivanvanderbyl

This comment has been minimized.

Show comment
Hide comment
@ivanvanderbyl

ivanvanderbyl Jan 11, 2013

Contributor

On initial tests it still seems to be broken. Has anything changed with regard to embedded: 'load' mappings?

Contributor

ivanvanderbyl commented Jan 11, 2013

On initial tests it still seems to be broken. Has anything changed with regard to embedded: 'load' mappings?

@brennanmceachran

This comment has been minimized.

Show comment
Hide comment
@brennanmceachran

brennanmceachran Mar 1, 2013

@ivanvanderbyl I think I'm having the same issue... did you ever get around it?

@ivanvanderbyl I think I'm having the same issue... did you ever get around it?

@ivanvanderbyl

This comment has been minimized.

Show comment
Hide comment
@ivanvanderbyl

ivanvanderbyl Mar 1, 2013

Contributor

Yeah afaik this is now resolved on master and has been for a month or so. Can you put together a fiddle with your issue and I'll see what needs changing to make it work.

Regards,
Ivan Vanderbyl

Sent from my iPhone

On 28/02/2013, at 9:39 PM, Brennan McEachran notifications@github.com wrote:

@ivanvanderbyl I think I'm having the same issue... did you ever get around it?


Reply to this email directly or view it on GitHub.

Contributor

ivanvanderbyl commented Mar 1, 2013

Yeah afaik this is now resolved on master and has been for a month or so. Can you put together a fiddle with your issue and I'll see what needs changing to make it work.

Regards,
Ivan Vanderbyl

Sent from my iPhone

On 28/02/2013, at 9:39 PM, Brennan McEachran notifications@github.com wrote:

@ivanvanderbyl I think I'm having the same issue... did you ever get around it?


Reply to this email directly or view it on GitHub.

@igorT

This comment has been minimized.

Show comment
Hide comment
@igorT

igorT Apr 9, 2013

Member

Closing due to inactivity.

Member

igorT commented Apr 9, 2013

Closing due to inactivity.

@igorT igorT closed this Apr 9, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment