`sideloadAssociations` being called more than once per association #556

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

raycohen commented Dec 27, 2012

If you have complex relationships, where you're loading multiple types with relations in common, the current code leaves it open for sideloadAssociations to be called twice with the same params and the same json hash, despite the best efforts of a loaded hash to prevent it.

This commit adds one more check to loaded, and a test that is not commented out.

Owner

wagenet commented Jan 9, 2013

@raycohen This doesn't merge cleanly anymore. Can you see if this is still an issue on master?

Contributor

raycohen commented Jan 28, 2013

@wagenet submitted #669 which should merge against current master

@raycohen raycohen closed this Jan 28, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment