Skip to content

Add assertions #657

Closed
wants to merge 1 commit into from

3 participants

@joliss
joliss commented Jan 23, 2013

I haven't been able to test either of these assertions, but we
encountered both of these issues, and I believe they'd have helped us
track them down much faster.

@joliss joliss Add assertions
I haven't been able to test either of these assertions, but we
encountered both of these issues, and I believe they'd have helped us
track them down much faster.
f47f66e
@darthdeus
Ember.js member

Can we merge this?

@igorT
Ember.js member
igorT commented Apr 6, 2013

Yup, this was a supper annoying bug. There are now asserts from b6d4f39

@igorT igorT closed this Apr 6, 2013
@joliss
joliss commented Apr 6, 2013

@igorT You added this one in b6d4f39, correct?

Ember.assert(fmt('Inverse relationship not found or ambiguous: parent %@, child %@, property %@; if ambiguous, add an `inverse` option on the property.', [parentType, childType, belongsToName]), inverseRelationship);

How about this one though, should this still be merged?

// Do not call `materialize` with undefined data.
Ember.assert(fmt('materializeData failed: No data found for clientId "%@"', [clientId]), data);
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.