Serialize embedded belongsTo as a foreign key #795

Closed
wants to merge 1 commit into
from

Projects

None yet

3 participants

@jasonkriss
Contributor

If a belongsTo association is specified to be '{ embedded: 'load' }', then it should be serialized as a foreign key, just as it would be if no embedded option was specified.

Note that the added test is currently failing due to #794

Owner
igorT commented Apr 5, 2013

Hey, can you rebase this against master so I can merge it. Thanks!

@jasonkriss jasonkriss Serialize embedded belongsTo as a foreign key
If a belongsTo association is specified to be '{ embedded: 'load' }',
then it should be serialized as a foreign key, just as it would be
if no embedded option was specified.
04d4f73
Contributor

@igorT Did you get a chance to look at #794? I rebased this pr and made a couple small changes, but the test I added is still failing due to the issue with keyForBelongsTo and { embedded: 'load' }.

Owner
wycats commented Sep 5, 2013

Embedded is gone, but let's make sure to consider this if/when we bring it back.

@wycats wycats closed this Sep 5, 2013
@jasonkriss jasonkriss deleted the jasonkriss:embedded-load branch Sep 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment